Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further cleanup to before/after blur #18649

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Further cleanup to before/after blur #18649

merged 1 commit into from
Apr 17, 2020

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Apr 17, 2020 •
edited

This is a follow up to #18636. This cleans up more code that was not really needed anymore and replaces it with simpler code. Instead of emulating the event through Flare, we pass through a native event that we listen to for both Flare and the modern event system, fixing an issue I found when doing the latest www sync.

@trueadm trueadm requested a review from necolas April 17, 2020 02:01
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 17, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ccc995f:

Sandbox Source
charming-glade-fmnfj Configuration

@sizebot
Copy link

sizebot commented Apr 17, 2020

Details of bundled changes.

Comparing: c5c25d3...ccc995f

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-test-utils.development.js 0.0% 0.0% 75.25 KB 75.25 KB 20.14 KB 20.15 KB UMD_DEV
ReactDOMTesting-profiling.js -0.1% -0.2% 403.32 KB 402.83 KB 73.34 KB 73.22 KB FB_WWW_PROFILING
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.1% 1.19 KB 1.19 KB 697 B 698 B UMD_PROD
ReactDOMForked-dev.js -0.1% -0.1% 1.03 MB 1.03 MB 236.07 KB 235.94 KB FB_WWW_DEV
ReactDOMForked-prod.js -0.1% -0.1% 446.32 KB 445.83 KB 77.95 KB 77.84 KB FB_WWW_PROD
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 5.28 KB 5.28 KB 1.73 KB 1.72 KB NODE_DEV
react-dom.development.js 0.0% 0.0% 906.25 KB 906.25 KB 199.43 KB 199.43 KB UMD_DEV
ReactDOMForked-profiling.js -0.1% -0.1% 457.28 KB 456.79 KB 79.88 KB 79.76 KB FB_WWW_PROFILING
react-dom.profiling.min.js 0.0% -0.0% 123.3 KB 123.3 KB 39.52 KB 39.52 KB UMD_PROFILING
ReactDOMTesting-dev.js -0.1% -0.1% 955.56 KB 954.9 KB 213.16 KB 213.02 KB FB_WWW_DEV
ReactDOMTesting-prod.js -0.1% -0.2% 403.32 KB 402.83 KB 73.34 KB 73.22 KB FB_WWW_PROD
ReactDOM-dev.js -0.1% -0.1% 1.03 MB 1.03 MB 235.9 KB 235.77 KB FB_WWW_DEV
ReactDOMServer-dev.js 0.0% 0.0% 165.06 KB 165.06 KB 41.95 KB 41.95 KB FB_WWW_DEV
ReactDOM-prod.js -0.1% -0.2% 445.73 KB 445.24 KB 77.87 KB 77.75 KB FB_WWW_PROD
ReactDOM-profiling.js -0.1% -0.2% 456.7 KB 456.21 KB 79.8 KB 79.68 KB FB_WWW_PROFILING
react-dom-test-utils.production.min.js 0.0% 0.0% 13.1 KB 13.1 KB 4.8 KB 4.8 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 56.1 KB 56.1 KB 13.84 KB 13.84 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.2% 1 KB 1 KB 609 B 610 B NODE_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% 0.0% 9.98 KB 9.98 KB 3.35 KB 3.36 KB UMD_PROD

Size changes (stable)

Generated by 🚫 dangerJS against ccc995f

@sizebot
Copy link

sizebot commented Apr 17, 2020

Details of bundled changes.

Comparing: c5c25d3...ccc995f

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactDOM-dev.js -0.1% -0.1% 1.01 MB 1.01 MB 231.01 KB 230.87 KB FB_WWW_DEV
ReactDOM-prod.js -0.1% -0.2% 434.72 KB 434.23 KB 76.31 KB 76.19 KB FB_WWW_PROD
ReactDOM-profiling.js -0.1% -0.2% 445.62 KB 445.13 KB 78.21 KB 78.08 KB FB_WWW_PROFILING
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.2% 1.02 KB 1.02 KB 617 B 618 B NODE_PROD
react-dom-test-utils.development.js 0.0% 0.0% 75.27 KB 75.27 KB 20.15 KB 20.15 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 13.24 KB 13.24 KB 4.9 KB 4.9 KB UMD_PROD
ReactDOMTesting-dev.js -0.1% -0.1% 929.01 KB 928.35 KB 207.61 KB 207.46 KB FB_WWW_DEV
ReactDOMTesting-prod.js -0.1% -0.2% 391.5 KB 391.01 KB 71.49 KB 71.37 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% 0.0% 70.1 KB 70.1 KB 19.65 KB 19.65 KB NODE_DEV
ReactDOMTesting-profiling.js -0.1% -0.2% 391.5 KB 391.01 KB 71.49 KB 71.37 KB FB_WWW_PROFILING
react-dom-test-utils.production.min.js 0.0% 0.0% 13.12 KB 13.12 KB 4.81 KB 4.81 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% 0.0% 23.75 KB 23.75 KB 8.76 KB 8.76 KB NODE_PROD
react-dom-server.browser.development.js 0.0% -0.0% 152.91 KB 152.91 KB 40.52 KB 40.52 KB NODE_DEV
ReactDOMForked-dev.js -0.1% -0.1% 1.01 MB 1.01 MB 231.17 KB 231.03 KB FB_WWW_DEV
ReactDOMForked-prod.js -0.1% -0.2% 435.29 KB 434.8 KB 76.39 KB 76.27 KB FB_WWW_PROD
react-dom.development.js 0.0% -0.0% 894.9 KB 894.9 KB 203.32 KB 203.32 KB NODE_DEV
ReactDOMForked-profiling.js -0.1% -0.2% 446.19 KB 445.7 KB 78.29 KB 78.17 KB FB_WWW_PROFILING
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 5.29 KB 5.29 KB 1.73 KB 1.73 KB NODE_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.1% 1.17 KB 1.17 KB 667 B 668 B NODE_PROD

Size changes (experimental)

Generated by 🚫 dangerJS against ccc995f

@trueadm trueadm requested a review from gaearon April 17, 2020 10:27
@trueadm trueadm merged commit e2ccbf0 into facebook:master Apr 17, 2020
@trueadm trueadm deleted the refine-before-blur branch April 17, 2020 10:52
trueadm added a commit to trueadm/react that referenced this pull request Apr 17, 2020
@trueadm
Revert "Further cleanup to before/after blur (facebook#18649)"
67d543a 
This reverts commit e2ccbf0.
trueadm added a commit that referenced this pull request Apr 17, 2020
@trueadm
Revert focus event PRs (#18655)
58c895e 
* Revert "Further cleanup to before/after blur (#18649)"

This reverts commit e2ccbf0.

* Revert "Unify Flare FocusWithin responder with useFocusWithin (#18636)"

This reverts commit f24a9e7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

@necolas necolas Awaiting requested review from necolas

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@trueadm @sizebot @gaearon @facebook-github-bot